Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Notice when changing the donation form title on the donation details page. #2377

Closed
2 tasks
emgk opened this issue Nov 21, 2017 · 2 comments
Closed
2 tasks
Assignees
Milestone

Comments

@emgk
Copy link
Contributor

emgk commented Nov 21, 2017

Issue Overview

Getting error when changing the Donation Form Title from the donation details page in the backend.
http://www.screencast.com/t/FX3KfHGlZp

Steps to Reproduce (for bugs)

  1. Go to any donation details page.
  2. Try to change Donation Form Title: option.
  3. See wp-content/debug.log

Todos

  • Tests
  • Documentation

WordPress Environment

``` ### WordPress Environment ###

Home URL: http://localhost/gv
Site URL: http://localhost/gv
WP Version: 4.9
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Inaccessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: localhost
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.25 (Win32) OpenSSL/1.0.2j PHP/7.0.18
PHP Version: 7.0.18
PHP Post Max Size: 8 MB
PHP Time Limit: 0
PHP Max Input Vars: 1000
PHP Max Upload Size: 2 MB
cURL Version: 7.51.0, OpenSSL/1.0.2j
SUHOSIN Installed: –
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ❌ Your server does not have the SoapClient class enabled - some gateway plugins which use SOAP may not work as expected.
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 1.8.17
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://localhost/gv/donation-confirmation/
Failure Page: http://localhost/gv/donation-failed/
Donation History Page: http://localhost/gv/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Admin Email Notifications: Enabled
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Other Active Plugins

Inactive Plugins

Give - Currency Switcher: by WordImpress – 1.0.0
Hello Dolly: by Matt Mullenweg – 1.6

Theme

Name: Twenty Seventeen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

</details>
@ravinderk ravinderk added the bug label Nov 21, 2017
@ravinderk ravinderk added this to the 1.8.17 milestone Nov 21, 2017
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 21, 2017
@raftaar1191
Copy link
Contributor

Nice catch @emgk

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 21, 2017
@raftaar1191 raftaar1191 mentioned this issue Nov 21, 2017
3 tasks
@DevinWalker DevinWalker changed the title Fatal error when changing the donation form title on the donation details page. PHP Notice when changing the donation form title on the donation details page. Nov 22, 2017
@DevinWalker
Copy link
Member

That's not a fatal error @emgk - that's a PHP notice. Not that major but still an issue.

DevinWalker added a commit that referenced this issue Nov 22, 2017
* release/1.8.17:
  1. Use give_get_total_earnings() rather than stats query for this year's donations - Fixes #2383 2. Favor late escaping
  Fix JS #2377
  Fix variable check #2377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants