Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notice): Dismiss button is missing in Give notices in front-end. #2853

Closed
2 tasks
emgk opened this issue Feb 28, 2018 · 0 comments
Closed
2 tasks

fix(notice): Dismiss button is missing in Give notices in front-end. #2853

emgk opened this issue Feb 28, 2018 · 0 comments
Assignees

Comments

@emgk
Copy link
Contributor

emgk commented Feb 28, 2018

Issue Overview

Notice in front-end area can't be dismissed

Give_Notices::print_frontend_notice( __( 'Sample notice', 'give' ), true );

In below screenshot there is no dismiss button.
screenshot-givecurrencyswitcher com-2018 02 28-16-28-48

Expected Behavior

  • Notices in front-end should be dismiss.

Current Behavior

  • Dismiss button is not there in front-end GIve notices.

Possible Solution

Related Issues and/or PRs

Todos

  • Tests
  • Documentation

WordPress Environment

``` ### WordPress Environment ###

Home URL: http://givecurrencyswitcher.com
Site URL: http://givecurrencyswitcher.com
WP Version: 4.9.4
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: givecurrencyswitcher.com
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: nginx/1.10.1
PHP Version: ❌ 5.3.29 - We recommend a minimum PHP version of 5.6. See: PHP Requirements in Give
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.2h - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.0.5
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access
Upgraded From: 2.0.2
Test Mode: Enabled
Currency Code: GBP
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://givecurrencyswitcher.com/donation-confirmation/
Failure Page: http://givecurrencyswitcher.com/donation-failed/
Donation History Page: http://givecurrencyswitcher.com/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Stripe - Credit Card, GoCardless, Authorize.net, Mollie Gateway, PayPal Payments Pro
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Give - Authorize.net Gateway: ❌ Unlicensed – by WordImpress – 1.3.3
Give - Currency Switcher: ❌ Unlicensed – by WordImpress – 1.0.1
Give - Fee Recovery: ❌ Unlicensed – by WordImpress – 1.4
Give - Form Field Manager: ❌ Unlicensed – by WordImpress – 1.2.8
Give - GoCardless Gateway: ❌ Unlicensed – by WordImpress – 1.1.2
Give - Manual Donations: ❌ Unlicensed – by WordImpress – 1.3.1
Give - Mollie Gateway: ❌ Unlicensed – by WordImpress – 1.0
Give - PayPal Pro Gateway: ❌ Unlicensed – by WordImpress – 1.1.4
Give - PDF Receipts: ❌ Unlicensed – by WordImpress – 2.2.4
Give - Razorpay: ❌ Unlicensed – by WordImpress – 1.1.1
Give - Stripe Gateway: ❌ Unlicensed – by WordImpress – 1.5.2

Other Active Plugins

Inactive Plugins

Debug Bar: by wordpressdotorg – 0.9
Debug Bar Post Meta: by whyisjake – 0.5.4
Duplicate Post: by Enrico Battocchi – 3.2.1
Give - Tributes: by WordImpress – 1.4.1
Give - Zapier: by WordImpress – 1.1.2

Active MU Plugins

Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0

Theme

Name: Twenty Seventeen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

</details>
@ravinderk ravinderk added the bug label Feb 28, 2018
@ravinderk ravinderk added this to the 2.0.6 milestone Feb 28, 2018
ravinderk added a commit that referenced this issue Mar 6, 2018
fix(notice): add ability to dismiss Give notices on front-end. #2853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants