New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(donation): implement sequential ordering #2912
Comments
@ravinderk I looked at how EDD implements sequential ordering, and it works like this:
Is that along the lines of what you were thinking? |
@kevinwhoffman I am not thinking to store latest donation max number to option table, rather I will dig into payment meta table to get max donation number. This seems to me like the safest way to avoid donation number clashes. |
@mathetos @DevinWalker @kevinwhoffman
|
@ravinderk would it be possible to only generate the Give Donation ID after it's marked as Complete? That would help alleviate a lot of confusion regarding pending donations, abandoned, etc. Until it's Complete, donations can be tracked with their respective transaction_id. There might be other nuances that I'm not taking into account, but off the top of my head that seems like the most straight-forward way to tackle this. |
@mathetos that is possible. |
@ravinderk If we go that route, we'd need to test and confirm the following as well:
Another consideration is how we will list these in the Donations screen. Currently they are all listed according to their Donation ID. What will replace the Donation ID for Pending Donations, Abandoned Donations, etc? Perhaps prefixed Ids, like "#p-102" (for pending) or "#a-103" (for abandoned). |
Edit: Disregard this proposal as we later decided that all attempted donations should receive a sequential ID in #2912 (comment). BehaviorI agree with @mathetos regarding the behavior. Remember that the reason customers want this is to prevent gaps in the sequence, so we should not assign sequential IDs until a donation is complete. To reiterate, the sequential ID should be assigned the first time that the donation achieves completed status (whether manually or through a gateway). We can ensure this happens by hooking into status change. If any change in status happens after the donation was completed, then the ID remains in place. Presentation
See mockup below. Since pending/abandoned donations will not have sequential IDs, I recommend we list them as ImplementationThe behavior described above assigns sequential IDs based on the |
Slack Chat Summary Participants: @DevinWalker, @ravinderk, @kevinwhoffman |
@ravinderk Devin and I are in agreement with the following approach which should simplify your tasks. Please assign a sequential ID to all attempted donations regardless of status. See my rationale below:
|
User Story
As an admin, I want sequential ordering feature in core so that I can see properly ordered donation on donation listing and other places and also helpful for tax purpose.
Tasks
The text was updated successfully, but these errors were encountered: