Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shortcode): load modal forms in form grid via AJAX #2951

Closed
2 tasks
kevinwhoffman opened this issue Mar 26, 2018 · 1 comment
Closed
2 tasks

fix(shortcode): load modal forms in form grid via AJAX #2951

kevinwhoffman opened this issue Mar 26, 2018 · 1 comment
Assignees

Comments

@kevinwhoffman
Copy link
Contributor

kevinwhoffman commented Mar 26, 2018

User Story

As a developer, I want to load modal forms in the form grid via AJAX so that I don't unnecessarily render multiple hidden forms that are never shown.

Current Behavior

I currently see that every form in the grid also renders a complete donation form that is hidden until the user clicks on the card. This is a waste of resources as the user will likely only click one card in any given visit.

Expected Behavior

I expect to load the form via AJAX, similar to how it's done for modal or one-button launch display styles.

Possible Solution

Investigate how modal/one-button launch forms are displayed for single forms and see if we can borrow some of that functionality for the form grid.

Visuals

This screenshot shows how every card in the grid is rendering a complete form on page load and then hiding the forms. This is not necessary.

image

See video for expected behavior: https://screencast-o-matic.com/watch/cFeOY6DAHY

Related

Tasks

  • Research how single forms are launched in modals via modal/one-button launch display styles.
  • Report a recommended solution in this issue.
@kevinwhoffman
Copy link
Contributor Author

@Sidsector9 Please wait until @DevinWalker merges #2943 into the 2.1 branch, and then create a new branch starting from the 2.1 branch.

@kevinwhoffman kevinwhoffman modified the milestones: Sprint: 2018/03/13 - 2018/03/28, Sprint: 2018/03/28 - 2018/04/10 Mar 28, 2018
DevinWalker pushed a commit that referenced this issue Apr 17, 2018
fix(shortcode): load modal forms in form grid via AJAX #2951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants