Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-plugins): correct number of plugins for Give filter #2953

Closed
DevinWalker opened this issue Mar 27, 2018 · 1 comment
Closed

fix(admin-plugins): correct number of plugins for Give filter #2953

DevinWalker opened this issue Mar 27, 2018 · 1 comment
Assignees
@raftaar1191
Milestone
Sprint: 2018/03/1...

Comments

@DevinWalker
Copy link
Member

User Story

As a user, I want be sure that the number of plugins for Give specifically appears accurately so that I know which plugins are only Give-related.

Current Behavior

The number is incorrect next to the filter:

2018-03-27_00-55-17
@raftaar1191
Copy link
Contributor

Finding

Here we were not looking for the author name so I add a new condition that will also check for the author name with the Plugin name

So now it will look for two thing on for Plugin Name and the Second one is for Author Name

Notes: Some Give Add-on has Author name as WordImpress, LLC and some have Author name as WordImpress so overcome this I am checking for string position in Author name

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Mar 27, 2018
@raftaar1191
fix(admin-plugins): Add check for author name impress-org#2953
348048a
@raftaar1191 raftaar1191 mentioned this issue Mar 27, 2018
Merged
5 tasks
DevinWalker pushed a commit that referenced this issue Mar 28, 2018
Merge pull request #2957 from raftaar1191/issues-2953
6b1a29e 
fix(admin-plugins): Add check for author name #2953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raftaar1191 raftaar1191

Labels
None yet
Projects
None yet
Milestone
Sprint: 2018/03/13 - 2018/03/28
Development

No branches or pull requests
3 participants
@DevinWalker @kevinwhoffman @raftaar1191