Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-plugins): display activation banner immediately upon activation refresh #3153

Closed
DevinWalker opened this issue May 2, 2018 · 4 comments
Closed

fix(admin-plugins): display activation banner immediately upon activation refresh #3153

DevinWalker opened this issue May 2, 2018 · 4 comments
Assignees
@raftaar1191
Milestone
Sprint: 2018/04/1...

Comments

@DevinWalker
Copy link
Member

DevinWalker commented May 2, 2018 •
edited by raftaar1191

User Story

As a admin, I want when I activate an addon that I see the activation banner immediately so that I can quickly access settings. Right now it's not displaying until I manually refresh the plugin listing page.

Acceptance Criteria

  • As an admin I can activate the plugin and

Visuals

See video: https://goo.gl/eevv6v
@emgk emgk mentioned this issue May 4, 2018
Merged
3 tasks
@raftaar1191
Copy link
Contributor

Finding

When activating the Give Add-on one by one it does not show me the message activation banner for both in fact it hides the last one and show the latest add-on notices which are been activated

Video link: https://screencast-o-matic.com/watch/cFhf0sbZIn

Example: In Give Core 2.0 it used to show Activation banner for all the add-on
image

Expected in Give Core 2.1.2
image

@raftaar1191 raftaar1191 reopened this May 4, 2018
@DevinWalker
Copy link
Member Author

Yeah that's intentional @raftaar1191 - no need to reopen.

@raftaar1191
Copy link
Contributor

Slack Chat Link: https://givewp.slack.com/archives/C0FAGC83C/p1525478063000074

@DevinWalker
Copy link
Member Author

Reopening pending ongoing review after speaking with @raftaar1191

@DevinWalker DevinWalker reopened this May 5, 2018
@ravinderk ravinderk assigned raftaar1191 and unassigned emgk May 8, 2018
@raftaar1191 raftaar1191 mentioned this issue May 8, 2018
Merged
3 tasks
DevinWalker pushed a commit that referenced this issue May 8, 2018
Merge pull request #3194 from raftaar1191/issue-3153
f0895bf 
fix(admin-plugins): display activation banner immediately upon activation refresh #3153
@DevinWalker DevinWalker mentioned this issue May 23, 2018
Merged
@DevinWalker DevinWalker mentioned this issue Jul 11, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raftaar1191 raftaar1191

Labels
None yet
Projects
None yet
Milestone
Sprint: 2018/04/18 - 2018/05/08
Development

No branches or pull requests
3 participants
@DevinWalker @emgk @raftaar1191