Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-dashboard): correct weekly donation total in dashboard widget #3156

Closed
ravinderk opened this issue May 3, 2018 · 1 comment
Closed

fix(admin-dashboard): correct weekly donation total in dashboard widget #3156

ravinderk opened this issue May 3, 2018 · 1 comment
Assignees
@ravinderk
Milestone
Sprint: 2018/04/1...

Comments

@ravinderk
Copy link
Collaborator

User Story

As an admin, I want correct weekly stat on my admin dashboard widget so that I can track donation earnings.

image
@ravinderk ravinderk self-assigned this May 3, 2018
@kevinwhoffman kevinwhoffman changed the title fix(donation): amdin dashboard widget is not shoqing correct this weekly stat fix(admin-dashboard): correct weekly donation total in dashboard widget May 3, 2018
ravinderk added a commit to ravinderk/Give that referenced this issue May 3, 2018
@ravinderk
fix(donation): improve if condition
4e359b9 
fixed impress-org#3156
@ravinderk ravinderk mentioned this issue May 3, 2018
Merged
3 tasks
@ravinderk
Copy link
Collaborator Author

@DevinWalker I found that this is a special case.

Week span is generating properly when the day of the week is same as the day of the month.

That means you will not face it after this day passed until above condition match.

for ref: https://github.com/WordImpress/Give/blob/release/2.2/includes/class-give-stats.php#L239

DevinWalker pushed a commit that referenced this issue May 3, 2018
Merge pull request #3158 from ravinderk/issues/3156
b3b0431 
fix(admin-dashboard): correct weekly donation total in dashboard widget #3156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
Sprint: 2018/04/18 - 2018/05/08
Development

No branches or pull requests
2 participants
@DevinWalker @ravinderk