Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shortcode): clarify Donation Form Grid shortcode generator #3166

Closed
3 tasks done
kevinwhoffman opened this issue May 3, 2018 · 1 comment
Closed
3 tasks done
Assignees

Comments

@kevinwhoffman
Copy link
Contributor

kevinwhoffman commented May 3, 2018

User Story

As a Give user, I want to understand what fields are optional in the shortcode generator so I don't have to know form IDs in order to use the new form grid.

Acceptance Criteria

  • I understand that the Form IDs field is optional.
  • I understand that when the field is blank, all forms are included in the grid.
  • There are no typos in tooltips.

Possible Solution

  1. Add All Forms as placeholder text to the field to clarify that by leaving that field blank, you are including all forms.
  2. Update the tooltip text to read: Enter a comma-separated list of form IDs. If empty, all published forms are displayed.
  3. Fix typo in Show Goal tooltip.

Steps to Reproduce

  1. Add post
  2. Open Give Shortcodes > Donation Form Grid.

Visuals

Solution

image

Additional Typo

image

Related

DevinWalker pushed a commit that referenced this issue May 3, 2018
fix(shortcode): clarify Donation Form Grid shortcode generator #3166
@ravinderk
Copy link
Collaborator

ravinderk commented May 4, 2018

Reopening this issue because if text false is set as default placeholder if the placeholder is undefined for textbox.

image

@ravinderk ravinderk reopened this May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants