Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-conflict): Give's bottom text overlapping on the Give's banner when storefront theme is activated. #3274

Closed
2 tasks done
emgk opened this issue May 29, 2018 · 0 comments
Assignees

Comments

@emgk
Copy link
Contributor

emgk commented May 29, 2018

User Story

As an Admin, I want to see the Give's thanks text on the bottom only and should not overlap on Give's Banner at all so that It can be better for UI/UX.

Current Behavior

I currently see the Give's thanks/version text is overlapping on the Give's Banner.

Expected Behavior

I expect text should not overrlap the banners.

Steps to Reproduce

  1. Install Storefront theme.
  2. Either install Give Fresh or delete all existing donation forms.
  3. Go to Give > Donation Form.

If your display screen is enough to cover both banner in visible part of the screen then zoom-in to re-produce the issue.

Visuals

layout-breaking

Tasks

  • Fix.
  • Test it with Storefront.

Environment

WordPress System Info ### WordPress Environment ###

Home URL: http://cs.test
Site URL: http://cs.test
WP Version: 4.9.6
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: cs.test
TLS Connection: Connection uses TLS 1.2
TLS Connection: Bad
Server Info: nginx/1.10.1
PHP Version: ❌ 5.3.29 - We recommend a minimum PHP version of 5.6. See: PHP Requirements in Give
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.2h - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.1.4
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access❌Renewal Receipt Email❌Subscription Cancelled Email
Upgraded From: 2.1.3
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://cs.test/donation-confirmation/
Failure Page: http://cs.test/donation-failed/
Donation History Page: http://cs.test/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Give - Currency Switcher: ❌ Unlicensed – by WordImpress – 1.1
Give - Recurring Donations: ❌ Unlicensed – by WordImpress – 1.6.2

Other Active Plugins

Inactive Plugins

Theme

Name: Twenty Seventeen
Version: 1.6
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Operating System
  • Platform: Mac OS X | Microsoft Windows | Linux | Android | iOS
  • Version: x.x.x
Browser
  • Name: Chrome | Firefox | Safari | IE | Edge
  • Version: x.x.x
DevinWalker pushed a commit that referenced this issue May 30, 2018
fix(admin-form): Give's bottom text overlapping on the Give's banner when storefront theme is activated. #3274
@DevinWalker DevinWalker changed the title fix(admin-form): Give's bottom text overlapping on the Give's banner when storefront theme is activated. fix(theme-conflict): Give's bottom text overlapping on the Give's banner when storefront theme is activated. Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants