Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(donation): prevent donation amount from updating multiple times #3304

Closed
ravinderk opened this issue Jun 1, 2018 · 0 comments
Closed

fix(donation): prevent donation amount from updating multiple times #3304

ravinderk opened this issue Jun 1, 2018 · 0 comments
Assignees
@ravinderk
Milestone
Sprint: 2018/05/2...

Comments

@ravinderk
Copy link
Collaborator

User Story

Due to some cause donation amount can be updated multiple time. which can cause of store wrong amount in DB.

for ref:
https://github.com/WordImpress/Give-Fee-Recovery/issues/198
https://github.com/WordImpress/Give/blob/release/2.1.4/includes/payments/class-give-payment.php#L1000
@ravinderk ravinderk self-assigned this Jun 1, 2018
ravinderk added a commit that referenced this issue Jun 1, 2018
@ravinderk
fix(donation): update donation amount only when property set
ae89449 
ref #3304
ravinderk added a commit that referenced this issue Jun 1, 2018
@ravinderk
Merge pull request #3305 from WordImpress/issue/3304
7d0eb03 
fix(donation): prevent donation amount from updating multiple times #3304
ravinderk added a commit that referenced this issue Jun 1, 2018
@ravinderk
Revert "fix(donation): prevent donation amount from updating multiple…
c4ab689 
… times #3304"
ravinderk added a commit that referenced this issue Jun 1, 2018
@ravinderk
Merge pull request #3309 from WordImpress/revert-3305-issue/3304
6167dd0 
Revert "fix(donation): prevent donation amount from updating multiple times #3304"
ravinderk added a commit that referenced this issue Jun 1, 2018
@ravinderk
fix(donation): change total property in pending when donation changed
07f1763 
ref #3304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
Sprint: 2018/05/23 - 2018/06/05
Development

No branches or pull requests
1 participant
@ravinderk