Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(donor-wall): improve donor wall performance and fix existing issues #3312

Closed
10 tasks done
DevinWalker opened this issue Jun 1, 2018 · 0 comments
Closed
10 tasks done
Assignees

Comments

@DevinWalker
Copy link
Member

DevinWalker commented Jun 1, 2018

Issue Overview

1. Improve query performance

Each time the grid is queried I see an excessive number of queries.

2. Comments are not saving or displaying properly

When you add a comment to the donation it does not display in the grid or in the admin.

2018-06-01_14-28-22

3. The comment metabox on the donation details needs to allow the comment to be edited. So it should display the comment in a text area regardless if there is a donation or not.

Make the donation comment editable by making this field a text area. Therefore admins can edit or go back and add/edit comments for donations.

2018-06-01_14-24-19

4. Support comment_length - The number of words to display for donation comments before a "Read more" field displays.

This is the number of words a donation comment will display be truncated before being cut off with a "Read more" text.

5. Support "Read more" text opening the entire comment in a modal window.

When someone clicks on the "Read more" text of a truncated column a give modal window should open with the entire comment for them to read.

6. Support customizing the "Read more" text via the readmore_text attribute

If an admin want to customize the "Read more" text for truncated comments they can do that by passing any string to this new attribute.

7. Support the only_comments bool attribute - this will only display donors with comments

If an admin only wants to display donors with comments then this will allow filtering the donor that do not have comments.

8. Support donation_amount and donation_count options for the orderby attribute

Admins need to be able to adjust the order of the donors by the total count of their donations or the total amount.

Count = 12 donations, 10 donations, 5, donations, 1 donations

Amount = $1,000 $500 $25

Note: if the counts the same (1, 1, 1,) then the order of those will be by latest donation by date first.

9. AJAXify the pagination so it doesn't have to have a page reload

Nearly all donor walls on sites like gofundme use AJAX rather than page reloads for pagination. This should apply to ours as well.

ToDo

  • Point 1 (removed duplicate quesy issue)
  • Point 2
  • Point 3
  • Point 4
  • Point 5
  • Point 6
  • Point 7
  • Point 8
  • Point 9
  • Test
ravinderk added a commit that referenced this issue Jun 4, 2018
@ravinderk ravinderk self-assigned this Jun 4, 2018
ravinderk added a commit that referenced this issue Jun 19, 2018
feat(donor-wall): improve donor wall performance and fix existing issues #3312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants