Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-upgrade): research DB upgrade issues #3383

Closed
ravinderk opened this issue Jun 19, 2018 · 2 comments

Comments

@ravinderk
Copy link
Collaborator

commented Jun 19, 2018

User Story

As an admin, I want hassle free DB upgrades in any server environment.

Matt's Comment

Call Summary
Participants: @ravinderk @mathetos

Consensus is that the current error message is the only place in which we can ensure that there is an actual problem. It is a vague error simply because we don't yet have enough information to know with certainty exactly why the DB update fails; it could be a lot of different things. In order to add better logic we need more information. We can't yet perfectly replicate DB update problems with Memcache for example. We can't yet perfectly replicate DB update problems with admin-ajax exactly as it happens in some of these environments. We don't know what types of server security prevents the database tables from being created. Without this information we can't have logic in the plugin that checks for these problems and gives better error messages.

To that end:

Matt will provide better wording for the existing error message, which will link to documentation that @Benunc is currently writing.
Matt will connect with Support and Devs at WooCommerce to see whether they face similar issues and what they do about it.
Ravinder will research the issue more in terms of how Woo/EDD deal with these from a code perspective.
For the next couple weeks, whenever @Benunc gets a DB update issue he should first ping Ravinder to work on it so Ravinder can see more environments with as many different scenarios as possible.
That's our plan moving forward. For this issue, let's keep it focused on a better error message that points to existing docs (that are not yet finished).

Ref #3267 (comment)

@Benunc

This comment has been minimized.

@ravinderk ravinderk added the Epic label Jun 21, 2018

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 13, 2018

We found that reason of most of DB update issue was that Ajax was inaccessible. In that case, background update is not possible. Since we can fire local ajax (on the page), so we can run completely update with local Ajax.

check this link for more information: https://github.com/wordimpress/give/issues/3420

@ravinderk ravinderk closed this Jul 13, 2018

@ravinderk ravinderk referenced this issue Feb 12, 2019
3 of 3 tasks complete
DevinWalker pushed a commit that referenced this issue Feb 20, 2019
Devin Walker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.