fix(emails): remove Give Shortcode button from the editor for creating emails

[Benunc]

User Story

As a give admin, I don't want options to add Give Shortcodes to emails because shortcodes don't work in emails.

Currently, when I navigate to Donations > Settings > Emails and select one of the emails to edit, there is an option to add give shortcodes to the emails.

If I am new to Give, I might think those are appropriate spots for Give shortcodes.

Current Behavior

I currently see the option for adding shortcodes to emails.

Expected Behavior

I expect to not be given the option to add shortcodes where they won't work.

Steps to Reproduce

1. Latest Master
2. Navigate to Donations > Settings > Emails (tab) and select an email to edit
3. There is a shortcode button there.

Visuals

Related

• https://secure.helpscout.net/conversation/609185954/20663?folderId=848135

Tasks

• remove the button from the visual tinymce editor on each email
• remove the button from the text tinymce editor
• confirm that the solution is extensible: emails added by add-ons also do not get the shortcode button

[ravinderk]

@Benunc @DevinWalker I think we should remove Give Shortcodes button from all setting pages because it will add to all wp editor, not just email.

Note: We can use give_shortcode_button_condition filter to show Give Shortcodes on custom pages

[ravinderk]

Closing in favor of cd544dd