Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): move babel-polyfill to Give core #3433

Closed
3 of 4 tasks
kevinwhoffman opened this issue Jul 3, 2018 · 3 comments
Closed
3 of 4 tasks

fix(compat): move babel-polyfill to Give core #3433

kevinwhoffman opened this issue Jul 3, 2018 · 3 comments
Assignees

Comments

@kevinwhoffman
Copy link
Contributor

kevinwhoffman commented Jul 3, 2018

User Story

As a developer, I want ES6 polyfills included in Give core so that they don't have to be enqueued multiple times in each add-on that requires them, which can result in conflicts like https://github.com/WordImpress/Give-Donation-Upsells-WooCommerce/issues/40.

Currently the WooCommerce and Stripe add-ons are incompatible so we need to take action immediately.

Possible Solution

@mehul0810 and I suggest enqueuing babel-polyfill with its own unique handle in Give core, while removing the polyfill from Stripe and WC add-ons.

Related

Tasks

  • Enqueue babel-polyfill in Give core.
  • Remove babel-polyfill from Stripe add-on.
  • Remove babel-polyfill from WooCommerce add-on.
  • Release patches for Give core, Stripe, and WC simultaneously.
@samsmith89
Copy link

When running NPM RUN DEV this throws an error because it isn't present. Is that intended behavior?
screen shot 2018-07-10 at 8 32 14 am

@ravinderk
Copy link
Collaborator

@samsmith89 I think this issue is with your plugin path. Rename Local Sites to Local-Sites

@raftaar1191
Copy link
Contributor

As this issues being fixed in Give Core version 2.1.7 so removing it from 2.2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants