Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email tags not working for specific email templates. #3510

Closed
1 task
Sidsector9 opened this issue Jul 20, 2018 · 2 comments
Closed
1 task

fix: email tags not working for specific email templates. #3510

Sidsector9 opened this issue Jul 20, 2018 · 2 comments
Assignees

Comments

@Sidsector9
Copy link
Contributor

Sidsector9 commented Jul 20, 2018

User Story

As a user, I want to see the description of only those email tags which are specific to the email notification type so that I don't use email tags which don't belong to the particular context.

As per observation, the following email tags should not be part of the following email notification type:

  • New Donation: {reset_password_link}
  • Donation Receipt: {reset_password_link},
  • New User Registration: {reset_password_link}, {email_access_link}
  • User Registration Information: {email_access_link}

Current Behavior

The above email tags do not work in their respective email notifications.

Expected Behavior

I expect to chose only those email template tags which are specific to the given context.

Tasks

  • Remove email template tags which are not applicable to the respective email botifications.
@kevinwhoffman kevinwhoffman changed the title fix(emails): Email tags not working for specific email templates. fix: email tags not working for specific email templates. Feb 1, 2019
@kevinwhoffman
Copy link
Contributor

@DevinWalker checked {reset_password_link} in the Donation Receipt email and confirmed this is still an issue. We should make sure any tags that appear in the email edit screen work as intended.

ravinderk added a commit that referenced this issue May 8, 2019
@ravinderk ravinderk self-assigned this May 8, 2019
@ravinderk
Copy link
Collaborator

@DevinWalker I was able to reproduce this issue:

New Donation: {reset_password_link} --> working now
Donation Receipt: {reset_password_link}, --> Working now
New User Registration: {reset_password_link}, {email_access_link} this is not pass of allowed email tag for this email
User Registration Information: {email_access_link} this is not pass of allowed email tag for this email

Testing Video: https://www.loom.com/share/56ba83e6a2394bd5bf7461dcbbdb0d56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants