Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-settings): refactor setting API to have custom save logic for setting sections #3541

Closed
ravinderk opened this issue Jul 31, 2018 · 0 comments
Assignees

Comments

@ravinderk
Copy link
Collaborator

User Story

As a developer, I want to have logic to set custom save logic for setting section.
For example Email setting page. Each core email data stores in give-settings which is getting bigger. The developer can easily create a custom setting page and option name which prevents him to store data in give-settings options.
We can not do that for a section like if we define a new email setting then it is difficult to store email data in custom option and render section with saved data.
For example reminder emails in https://github.com/WordImpress/Give-Recurring-Donations/issues/640

ravinderk added a commit that referenced this issue Aug 8, 2018
fix(admin-settings): refactor setting API to have custom save logic for setting sections #3541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants