Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow 8 number of decimal position for bitcoin #3602

Closed
ravinderk opened this issue Aug 14, 2018 · 4 comments
Closed

fix: allow 8 number of decimal position for bitcoin #3602

ravinderk opened this issue Aug 14, 2018 · 4 comments
Assignees

Comments

@ravinderk
Copy link
Collaborator

User Story

As an admin, I want to the donor to allow donor to donate in bitcoin but it need 8 number of decimal precision.

Currently, we can only set < 8 number of decimal precision because 8 is preserved for core amount formatting, which allows to easily sanitize formatted or unformatted number.

Source: https://wordpress.org/support/topic/error-btc-currency-always-defaults-to-5-digits-even-when-setup-8-digits/

@ravinderk
Copy link
Collaborator Author

ravinderk commented Aug 20, 2018

@DevinWalker Bumping up this issue because it can break few addons because it is directly related to amount formatting.

DevinWalker pushed a commit that referenced this issue Aug 29, 2018
fix(currency): allow 8 number of decimal position for bitcoin #3602
@raftaar1191
Copy link
Contributor

@ravinderk will test this PR with other add-on and will let you know

@raftaar1191
Copy link
Contributor

@ravinderk
Copy link
Collaborator Author

This issue still opens because my review is pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants