chore: add php 7.2 and 7.3 support for unit test with travis #3794
Comments
|
I added 7.2 and 7.3 testing but now we're running into some PHPunit compatibility issues: PHPUnit compatibility page: https://phpunit.de/supported-versions.html |
|
I did some research and it looks like this is a WP Core PHPUnit testing issue that is set to be resolve in release I'm going to remove the code to test PHP |
* release/2.4.1: (35 commits) refactor: remove old donation form exporter code chore: removed unnecessary code causing PHP warning and function cleanup fix: resolved make user actual logged out when click log out link chore: add method description fix: allow json uploads for settings import screen only on WP 5.0+ #3907 fix: resolved php notice when donor address update chore: comment out PHPUnit testing code #3794 chore: update plugin version to 2.4.1 chore: add PHP 7.2 + 7.3 to travis tests fix: resolved log count is not correct when search for API log related to specific WP User fix: improve logic for cc field server side validations fix: company_name and name tag description changed as per requested fix: prevent error when exporting CSV between two dates fix: email tag description changed as per suggestion fix: allowed admin to update blank value for address input fix: improve conditional logic to work for stripe checkout as well fix: snippet added for make compatible X theme and Cornerstone plugin fix: add support for empty validation check to cc fields fix: php ruleset added for check give text domain chore: run npm update and test tasks to ensure compatibility ...
* release/2.4.1: (39 commits) refactor: remove old donation form exporter code chore: removed unnecessary code causing PHP warning and function cleanup fix: resolved make user actual logged out when click log out link chore: add method description fix: allow json uploads for settings import screen only on WP 5.0+ #3907 fix: resolved php notice when donor address update chore: comment out PHPUnit testing code #3794 chore: update plugin version to 2.4.1 chore: add PHP 7.2 + 7.3 to travis tests fix: resolved log count is not correct when search for API log related to specific WP User fix: improve logic for cc field server side validations fix: company_name and name tag description changed as per requested fix: prevent error when exporting CSV between two dates fix: email tag description changed as per suggestion fix: allowed admin to update blank value for address input fix: improve conditional logic to work for stripe checkout as well fix: snippet added for make compatible X theme and Cornerstone plugin fix: add support for empty validation check to cc fields fix: php ruleset added for check give text domain chore: run npm update and test tasks to ensure compatibility ...
kevinwhoffman
modified the milestones:
Sprint: 2019/01/16 - 2019/01/29,
Sprint: 2019/01/30 - 2019/02/12
* release/2.4.1: (25 commits) fix: covert microtime to string chore: fix typo fix: param typo Revert "fix: ensure donor mailing addresses match when exporting to csv" fix: resolved donor export not correct when export donor. refactor: remove old donation form exporter code chore: removed unnecessary code causing PHP warning and function cleanup fix: resolved make user actual logged out when click log out link chore: add method description fix: allow json uploads for settings import screen only on WP 5.0+ #3907 fix: resolved php notice when donor address update chore: comment out PHPUnit testing code #3794 chore: update plugin version to 2.4.1 chore: add PHP 7.2 + 7.3 to travis tests fix: resolved log count is not correct when search for API log related to specific WP User fix: improve logic for cc field server side validations fix: company_name and name tag description changed as per requested fix: prevent error when exporting CSV between two dates fix: email tag description changed as per suggestion fix: allowed admin to update blank value for address input ...
|
@DevinWalker have a look at my repo: https://github.com/koconder/wordpress-test-template and a plugin you can see the Travis CI setup on: https://github.com/koconder/wordpress-test-template Shout if you need me to jump in and build out a PR for your issue or help test your Travis CI configuration. |
|
It's https://github.com/impress-org/give/blob/release/2.4.1/tests/bin/install.sh that is majorly outdated, I have in the test plugin a reference to the main repo where I maintain the Travis CI setup and .sh install scripts. |
kevinwhoffman
modified the milestones:
Sprint: 2019/01/30 - 2019/02/12,
Sprint: 2019/02/13 - 2019/02/26
kevinwhoffman
modified the milestones:
Sprint: 2019/02/13 - 2019/02/26,
Sprint: 2019/02/27 - 2019/03/12
kevinwhoffman
modified the milestones:
Sprint: 2019/02/27 - 2019/03/12,
Sprint: 2019/03/13 - 2019/03/26
kevinwhoffman
modified the milestones:
Sprint: 2019/03/13 - 2019/03/26,
Sprint: 2019/03/27 - 2019/04/09
|
Now that WP supports PHPUnit 7.x we now have a new release of PHPUnit 8.x which WP does not support. This results in the following issue now with my recent changes:
|
|
@DevinWalker as per my last messages. You can see an example here from my boilerplate repo https://github.com/koconder/wordpress-test-template Test results: https://travis-ci.org/koconder/wordpress-test-template/builds/547591604
@DevinWalker @mehul0810 @kevinwhoffman - I'm happy to jump in and resolve |
|
@koconder that looks passing for sure. I wasn't able to achieve that but it's been a few months since I tried. If you would like to contribute towards getting this issue resolved we'd love to have a PR! Thanks for the follow up. |
|
@DevinWalker i'll give it a go for you guys! |
|
@koconder If you're still interested in giving another look at this one it would be appreciated. |
|
We no longer use Travis and are testing for these versions upon release. |
Feature Request
User Story
As a user, I want to see Give works properly with PHP 7.2 and 7.3 so that there are no errors.
Note: We can work on this issue in mid-December this year as PHP 7.3 is scheduled to release in December 2018, so that we can add support for both PHP versions at the same time without wasting any additional time.
Visuals
PHP Versions supported with Travis currently
Acceptance Criteria
The text was updated successfully, but these errors were encountered: