Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve ordering of donor wall #3816

Closed
4 tasks done
kevinwhoffman opened this issue Oct 30, 2018 · 3 comments
Closed
4 tasks done

feat: improve ordering of donor wall #3816

kevinwhoffman opened this issue Oct 30, 2018 · 3 comments
Assignees

Comments

@kevinwhoffman
Copy link
Contributor

kevinwhoffman commented Oct 30, 2018

Feature Request

User Story

As a user, I want more control over the order and orderby parameters of the donor wall so that I can display donors in the order I want.

From the user:

I was thinking we’d be able to do a [ give_donor_wall form_id=”1234″ donors_per_page=”5″ orderby=”total” ] to do like a “Wall of Fame” for our best donors.

Visuals

image

Possible Solution

Add the following fields to the shortcode builder:

Order

  • Descending : DESC (default)
  • Ascending : ASC

Order by

  • Date : date (default)
  • Donation Amount : donation_amount

Possibly filter the following values:

https://github.com/impress-org/give/blob/83aa79a3b33a90a8c13719ec22c65ed0621c306c/includes/donors/class-give-donor-wall.php#L301

https://github.com/impress-org/give/blob/83aa79a3b33a90a8c13719ec22c65ed0621c306c/includes/donors/class-give-donor-wall.php#L414

Related

https://wordpress.org/support/topic/orderby-in-donor_wall/

Acceptance Criteria

  • An Order field is available in the shortcode builder which defines the order parameter.
  • An Order by field is available in the shortocde builder which defines the orderby parameter.
  • Ordering by date causes donors to be displayed chronologically.
  • Ordering by donation_amount causes donors to be ordered based on the size of each individual donation.
@kakshak
Copy link

kakshak commented Nov 1, 2018

Slack Call Summary

Participants: @kakshak , @mehul0810
Topic: Discussion about query regarding Donation Amount
Result: I am confused at the query and I have a conversion with Mehul that how to resolve that using custom query but We need to figure out a way that how we can modify that in a simplified way. So, I am looking over it right now and if I required help then I'll make a conversation with Mehul.

@ravinderk
Copy link
Collaborator

@kevinwhoffman I found that Order By setting is missing from Gutenberg block, so I am working on fix.

image

@ravinderk
Copy link
Collaborator

Issue has been fixed in a768249...f16fc4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants