New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort form grid by goal progress #3818
Comments
@kakshak please consult with @mehul0810 as to whether either one of these is possible:
|
Slack Call SummaryParticipants: @kakshak , @mehul0810 |
@kakshak Do not worry about ordering by |
Slack Call SummaryParticipants: @kakshak @ravinderk @kevinwhoffman For example:
This goal progress would be updated when the form is saved or when a donation occurs. One concern regarding backwards compatibility is that a DB update would be required in order to add this normalized goal progress as form meta for existing forms. Since this is a more complex implementation than the other order methods, I will discuss with @DevinWalker to decide whether to pursue the feature. |
@kakshak Devin confirmed in Slack that we can move forward on this feature. As we discussed above, this functionality will require a new form meta key to be added for each form going forward in addition to a database upgrade routine so that existing forms get the same key. |
@kevinwhoffman I've added the acceptance criteria for this flow. Please review it and let me know about it. |
@kakshak Review this commit: d8a061c...382e42f @kakshak when sort form grid on basis of goal then admin form listing and front form list is different, can you review that? @kevinwhoffmanthere there can be forms in Form Grid which do not has a goal but still, we are storing goal progress in meta key for sorting purpose. How do you want to sort these |
@ravinderk Ideally all of the forms without goals set at all appear at the end of the list, after forms that do have goals without progress. This may require sorting by a secondary meta key so that the forms are grouped together like so:
|
@kevinwhoffman @kakshak Acceptance criteria updated: #3818 (comment) |
Slack Call SummaryParticipants: @kakshak @ravinderk |
@ravinderk I've checked the |
* release/2.4.0: fix: update wpcs code formatting fix: resolve query for no goal exist to check if metakey is empty. resolve PHP notice and simplified give_form_search_query function refactor: provide better CSS for responsiveness and to match other filter bars in Give refactor: remove comment scss code refactor: print advance form search option before bulk actions feat: advanced filter added for donation list, query filter added for search result temp commit local changes before pull #3818
* release/2.4.0: fix: update wpcs code formatting fix: resolve query for no goal exist to check if metakey is empty. resolve PHP notice and simplified give_form_search_query function refactor: provide better CSS for responsiveness and to match other filter bars in Give refactor: remove word "sales" from dashboard stats widget functions fix: add missing custom comment table before moving notes style: improve id and function naming feat: load dashboard widget with ajax fix: if callback for upgrade will be array then first parameter will be object of callback class fix: dynamically call the method of a class fix: improve code as optional param is now required so no conditions fix: update indirect access variable to support php 5 and 7 refactor: remove comment scss code refactor: print advance form search option before bulk actions feat: advanced filter added for donation list, query filter added for search result temp commit local changes before pull #3818
* release/2.4.0: docs: use proper @param to ref WP_Query fix: update wpcs code formatting fix: resolve query for no goal exist to check if metakey is empty. resolve PHP notice and simplified give_form_search_query function refactor: provide better CSS for responsiveness and to match other filter bars in Give refactor: remove word "sales" from dashboard stats widget functions fix: query added for search by first name + last name fix: add missing custom comment table before moving notes style: improve id and function naming feat: load dashboard widget with ajax fix: if callback for upgrade will be array then first parameter will be object of callback class fix: dynamically call the method of a class fix: convert donation id to int before comparision fix: remove double px border for first thead th cell fix: improve code as optional param is now required so no conditions fix: update indirect access variable to support php 5 and 7 refactor: remove comment scss code refactor: print advance form search option before bulk actions feat: advanced filter added for donation list, query filter added for search result temp commit local changes before pull #3818
Feature Request
User Story
As a site admin, I want to order my form grid by those that are expiring soonest and by forms that are closest to meeting their goal so that can create a sense of urgency on particular forms.
Possible Solution
Providing this as an option in the Give shortcode builder.
Related
https://secure.helpscout.net/conversation/693671917/27970/
Acceptance Criteria
Closest To Goal
parameter in Order by a parameter inDonation Form Grid
shortcode generator.Closest To Goal
parameter from shortcode generator the Form will be the sort that is nearest to goal.Closest To Goal
parameter in Order by a parameter in Gutenberg Form Grid block setting ( @ravinderk )give_totals
shortcode and use goal progress meta key in logic if requiredThe text was updated successfully, but these errors were encountered: