New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: give session cookie prefix #3819
Comments
@mehul0810 Please look into this issue on the Pantheon server. If you need to manipulate the cookie name, you can change the coookie name on this line using the Dashboard > Plugins > Edit screen.
|
As a reference, this is the snippet we sent to customers as a workaround for this issue:
|
@mathetos @kevinwhoffman We already addressed this issue because Pantheon only allow cookies with specific prefix: #3705 (comment) I will suggest adding support for Pantheon host in core if a user coming so often. Pantheon host defines |
Slack Call SummaryParticipants: @mehul0810 @ravinderk |
Slack Call SummaryParticipants: @mehul0810 @ravinderk |
fix: give session cookie prefix #3819
Bug Report
User Story
As a web host like Pantheon, we exclude sessions cookies from caching when they are prefixed according to the WP Codex cookie naming convention of
wp-
.Current Behavior
Give currently names its cookies with an underscore, as in
wp_give_session
. This means that Give users on Pantheon cannot see their donation confirmation receipt successfully but see the email access or login form instead.https://github.com/impress-org/give/blob/7836ac3e98ee80a6ab5e60968cd99567b7a6b9ae/includes/class-give-session.php#L304-L308
Expected Behavior
I expect the Give cookies to follow the WP Codex naming convention so that cookies are named more predictably for hosts.
Bug Type
Steps to Reproduce
wp-
Possible Solution
Change the cookie name with backward compatibility.
Acceptance Criteria
Environment
Home URL: http://dev-givetesting.pantheonsite.io
Site URL: http://dev-givetesting.pantheonsite.io
WP Version: 4.9.8
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval
Server Environment
Hosting Provider: DBH: 10.128.0.124:16302, SRV: appserver-26b699e6.c.pantheon-dmz.internal
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: nginx/1.8.1
PHP Version: 7.2.11
PHP Post Max Size: 100 MB
PHP Time Limit: 120
PHP Max Input Vars: 10000
PHP Max Upload Size: 100 MB
cURL Version: 7.40.0, NSS/3.21 Basic ECC
SUHOSIN Installed: –
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔
Give Configuration
Give Version: 2.3.0
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://dev-givetesting.pantheonsite.io/donation-confirmation/
Failure Page: http://dev-givetesting.pantheonsite.io/donation-failed/
Donation History Page: http://dev-givetesting.pantheonsite.io/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled
Active Give Add-ons
Other Active Plugins
Inactive Plugins
Akismet: by Automattic – 3.1.5
Hello Dolly: by Matt Mullenweg – 1.6
My Custom Functions: by Space X-Chimp – 4.30
Native PHP Sessions for WordPress: by Pantheon – 0.6.9
WP Rollback: by WordImpress – 1.5.1
Active MU Plugins
Pantheon: by Pantheon – 0.1
Theme
Name: Twenty Seventeen
Version: 1.0
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme
Browser
WordPress System Info
The text was updated successfully, but these errors were encountered: