Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation: Default Settings Not Saving Properly #40

Closed
DevinWalker opened this issue Mar 18, 2015 · 2 comments
Closed

Installation: Default Settings Not Saving Properly #40

DevinWalker opened this issue Mar 18, 2015 · 2 comments
Assignees
@DevinWalker
Milestone
0.8 Beta

Comments

@DevinWalker
Copy link
Member

When you first activate the plugin the default settings should be populated by default in the database. Right now the user has to goto settings and click "Save" in order for this to happen. This can lead to issues if the user simply chooses to not save any settings and decides to rather start building forms.

CMB2 issue opened: CMB2/CMB2-Snippet-Library#6
@DevinWalker DevinWalker self-assigned this Mar 18, 2015
@DevinWalker DevinWalker added this to the 0.8 Beta milestone Mar 18, 2015
This was referenced Mar 18, 2015
Closed
Closed
@DevinWalker
Copy link
Member Author

Also affecting install when the default pages are created, such as "Donation History", and should be prepopulating the General Settings.

@bryanmonzon bryanmonzon mentioned this issue Mar 20, 2015
Closed
@DevinWalker DevinWalker mentioned this issue Mar 20, 2015
Closed
@DevinWalker
Copy link
Member Author

Default values now populated for NEW installs only:

Success Page (page also created if value not set)
Failure Page
History Page

Base Country = US
Test Mode = Active
Gateways = Test Gateway

Admin Donation Email Notification = Default Set

@DevinWalker DevinWalker mentioned this issue Mar 21, 2015
Closed
DevinWalker pushed a commit that referenced this issue Oct 10, 2016
@ramiy
Merge pull request #40 from WordImpress/release/1.7
2293794 
Merge updates
jonwaldstein added a commit to jonwaldstein/givewp that referenced this issue Aug 15, 2023
@jonwaldstein
Feature: classic template (impress-org#40)
94ab1db 
* feature: scaffold start of classic template overrides

* refactor: remove additional conditional

* refactor: adjust structure of base form elements including abiliy to override html tags

* refactor: update base form to include submit inside a section

* feature: first pass classic template structure and amount field

* feature: add setFocus to custom amount

* feature: use classNames package for className conditionals

* feature: add support for field level error styling

* refactor: get formState from useFormState hoook

* fix: search for updated node names

* feature: add name prop to NodeWrapper for parent div styling

* feature: improve form styles with updated gateway field styles

* feature: add submit button hover

* refactor: start isolating FormSections into seperate component for resolving nested rerenders and validation focus issue

* feature: add border radius to bottom

* feature: update input labels

* refactor: convert amount field to BEM structure

* refactor: update component to use types

* chore: cleanup unused and add comments

* fix: scss typo

* chore: update type import locations

* refactor: move utility functions into seperate files

* feature: create SectionNode component and wrap template functions in useMemo

* refactor: get rid of unnecessary loopy components and move sections back into form now

* feature: take a step further and seperate node types

* chore: format file, c'mon phpstorm

* chore: y u no format

Co-authored-by: Jon Waldstein <jonwaldstein@jons-air.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
0.8 Beta
Development

No branches or pull requests
1 participant
@DevinWalker