Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure do not set default autocomplete on every dropdown fields #4028

Closed
3 of 5 tasks
ravinderk opened this issue Mar 4, 2019 · 0 comments
Closed
3 of 5 tasks

fix: ensure do not set default autocomplete on every dropdown fields #4028

ravinderk opened this issue Mar 4, 2019 · 0 comments
Assignees
@ravinderk
Milestone
Sprint: 2019/02/2...

Comments

@ravinderk
Copy link
Collaborator

ravinderk commented Mar 4, 2019 •
edited

Bug Report

Current Behavior

I am setting autocomplete attribute set to address-level1 on each select field which is generated dynamically.

Expected Behavior

autocomplete must set parameter pass to function.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Possible Solution

Allow editing autocomplete attribute with autocomplete param to select function

Acceptance Criteria

  • disable autocomplete attribute by default (by setting it to no).
  • autocomplete attribute is set to value, we are passing to Give_HTML_Element::select function.
@ravinderk ravinderk self-assigned this Mar 4, 2019
@ravinderk ravinderk mentioned this issue Mar 4, 2019
Merged
3 tasks
@ravinderk ravinderk changed the title fix: ensure do not set default autocomplete every dropdown fields fix: ensure do not set default autocomplete on every dropdown fields Mar 4, 2019
DevinWalker pushed a commit that referenced this issue Mar 4, 2019
Merge pull request #4029 from impress-org/hotfix/select_autocomplete
f789fab 
fix: ensure do not set default autocomplete on every dropdown fields #4028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
Sprint: 2019/02/27 - 2019/03/12
Development

No branches or pull requests
1 participant
@ravinderk