Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit test to check for valid JSON object returned in API #4074

Closed
1 task done
DevinWalker opened this issue Apr 2, 2019 · 0 comments
Closed
1 task done
Assignees

Comments

@DevinWalker
Copy link
Member

DevinWalker commented Apr 2, 2019

Feature Request

This is a request for a simple unit test to check for valid JSON results returned from the various Give Core API endpoints as a result of this issue: #4071 which resulted in hours of debugging Zapier to no avail in https://github.com/impress-org/give-zapier/issues/38

User Story

As a developer I want to ensure the Give API always returns valid JSON so that my integrations continue working as expected when the plugin updates.

Possible Solution

Add unit test for results returned from API

Related

#4071 and Zapier issue: https://github.com/impress-org/give-zapier/issues/38

Acceptance Criteria

  • Before Give is released a unit test is ran which tests the validity of the API result formats
@ravinderk ravinderk self-assigned this Apr 3, 2019
DevinWalker pushed a commit that referenced this issue Apr 4, 2019
fix: Give API returns inconsistent amount formats #4073 and feat: add unit test to check for valid JSON object returned in API #4074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants