fix: add a thousand separator to goal when displaying number of donors and number of donations

[samsmith89]

Bug Report

User Story

As a site admin, I want a thousand separator for my Number of Donors and Number of Donations donation form goal so numbers over a thousand show properly.

Current Behavior

Currently, I have a donation form that has a goal of 125,000 donors. It shows with a thousand separator like a comma as "125000".

Expected Behavior

I expect to have a thousand separator for numbers over a thousand.

Bug Type

• This bug describes functionality that once worked as expected in version X.X.X.
• This bug describes functionality that never worked as expected.
• I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

1. Create a donation form with a goal of 125,000 donors
2. See that no thousand separator displays
3. Can't place a thousand separator in the settings

Visuals

Related

https://secure.helpscout.net/conversation/849293061/39627

Acceptance Criteria

• There is a thousand separator for goal numbers over a thousand.

Environment

Operating System

• Platform: Mac OS X

Browser

• Name: Chrome

WordPress System Info

### WordPress Environment ###

Home URL: http://give.local
Site URL: http://give.local
WP Version: 5.1.1
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, acf-disabled, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.10 (Debian)
PHP Version: 7.1.4
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.4.6
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Database Tables: ✔ wp_give_donors - 1.0✔ wp_give_donormeta - 1.0✔ wp_give_comments - 1.0✔ wp_give_commentmeta - 1.0✔ wp_give_sessions - 1.0✔ wp_give_logs - 1.0✔ wp_give_logmeta - 1.0✔ wp_give_formmeta - 1.0✔ wp_give_sequential_ordering - 1.0✔ wp_give_donationmeta - 1.0
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access✔Renewal Receipt Email❌Renewal Receipt Email✔Subscription Cancelled Email❌Subscription Cancelled Email❌Subscription Completed Email✔Subscription Reminder Email✔Subscriptions Email Access
Upgraded From: 2.4.5
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://give.local/donation-confirmation/
Failure Page: http://give.local/donation-failed/
Donation History Page: http://give.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Stripe - Credit Card, Mollie Gateway, Test Donation
Default Payment Gateway: Mollie Gateway
PayPal IPN Verification: Disabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - Annual Receipts: ✔ Licensed – by GiveWP – 1.0.2
Give - Authorize.net Gateway: ✔ Licensed – by GiveWP – 1.4.6
Give - Braintree Gateway: ✔ Licensed – by GiveWP – 1.2.4
Give - CCAvenue Gateway: ✔ Licensed – by GiveWP – 1.0.4
Give - Donation Upsells for WooCommerce: ✔ Licensed – by GiveWP – 1.1.1
Give - Fee Recovery: ✔ Licensed – by GiveWP – 1.7.4
Give - Form Countdown: ❌ Unlicensed – by WordImpress – 1.0.1
Give - Form Field Manager: ✔ Licensed – by GiveWP – 1.4.3
Give - Gift Aid: ✔ Licensed – by GiveWP – 1.2.1
Give - Google Analytics Donation Tracking: ✔ Licensed – by GiveWP – 1.2.1
Give - MailChimp: ✔ Licensed – by GiveWP – 1.4.4
Give - Manual Donations: ✔ Licensed – by GiveWP – 1.4.3
Give - Mollie Gateway: ❌ Unlicensed – by GiveWP – 1.2.1
Give - PayPal Pro Gateway: ✔ Licensed – by GiveWP – 1.2.1
Give - Paytm Gateway: ✔ Licensed – by GiveWP – 1.1.0
Give - PDF Receipts: ✔ Licensed – by GiveWP – 2.3.3
Give - Recurring Donations: ✔ Licensed – by GiveWP – 1.8.13
Give - Square: ❌ Unlicensed – by GiveWP – 1.0.1
Give - Stripe Gateway: ✔ Licensed – by GiveWP – 2.1.8
Give - Tributes: ✔ Licensed – by GiveWP – 1.5.3
Sam's Helper Function: ❌ Unlicensed – by WordImpress – 1.0

Other Active Plugins

Advanced Custom Fields: by Elliot Condon – 5.7.12
All-in-One WP Migration: by ServMask – 6.83
Give - Hook Helper: by Ravinder Kumar – 1.0
Jetpack by WordPress.com: by Automattic – 7.1.1
Notification: by BracketSpace – 5.3.2
Transients Manager: by Pippin Williamson – 1.7.5
User Role Editor: by Vladimir Garagulya – 4.49
WP Business Reviews: by Impress.org – 1.2.0

Inactive Plugins

Amelia: by TMS – 1.4.4
Classic Editor: by WordPress Contributors – 1.4
Cookie Notice: by dFactory – 1.2.46
GDPR Cookie Consent: by WebToffee – 1.7.6
GDPR Cookie Consent Banner: by termly – 2.3.14
Give - Currency Switcher: by GiveWP – 1.3.1
Give - Email Reports: by WordImpress – 1.1.2
Give - GoCardless Gateway: by WordImpress – 1.2.1
Give - Razorpay: by WordImpress – 1.2.0
WooCommerce: by Automattic – 3.5.5
WordPress Importer: by wordpressdotorg – 0.6.4

Active MU Plugins

Bypass Login: by Stephen Carnam – 1.1.0

Theme

Name: Twenty Seventeen
Version: 2.0
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme