Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the stripe connect banner has appearance issues and the temporary disabling of it no longer works #4175

Closed
5 tasks done
DevinWalker opened this issue Jul 12, 2019 · 0 comments · Fixed by #4179
Closed
5 tasks done

fix: the stripe connect banner has appearance issues and the temporary disabling of it no longer works #4175

DevinWalker opened this issue Jul 12, 2019 · 0 comments · Fixed by #4179
Assignees
@mehul0810
Milestone
July 2019

Comments

@DevinWalker
Copy link
Member

DevinWalker commented Jul 12, 2019 •
edited by mehul0810

Issue Overview

The Stripe connect banner does not have the same font size as it used to and the "Not right now" text doesn't work when clicked.

Related to #4157

Acceptance Criteria

  • Reproduce the issue
  • Ensure that the connect banner has proper font size
  • Ensure that the connect banner don't have 2 dismiss icons when Stripe add-on is active
  • Ensure that the connect banner is dismissble for 24 hours irrespective of Stripe add-on is active or not.
  • Testing
@DevinWalker DevinWalker changed the title fix: the stripe connect banner fix: the stripe connect banner has appearance and the temporary disabling of it no longer works Jul 12, 2019
@DevinWalker DevinWalker changed the title fix: the stripe connect banner has appearance and the temporary disabling of it no longer works fix: the stripe connect banner has appearance issues and the temporary disabling of it no longer works Jul 12, 2019
@mehul0810 mehul0810 mentioned this issue Jul 15, 2019
Merged
3 tasks
ravinderk added a commit that referenced this issue Jul 15, 2019
@ravinderk
Merge pull request #4179 from impress-org/issue/4175
753a326 
fix: the stripe connect banner has appearance issues and the temporary disabling of it no longer works #4175
@ravinderk ravinderk added this to the July 2019 milestone Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehul0810 mehul0810

Labels
None yet
Projects
None yet
Milestone
July 2019
3 participants
@DevinWalker @ravinderk @mehul0810