fix: don't override Stripe email notification settings

[mathetos]

Bug Report

User Story

As a site admin, I want to control whether Stripe sends email notifications to my donors or not. I can do that within my Stripe settings; I don't want my plugins overriding that setting. I expect that when I have this control, my donors will always only get one donation receipt, not multiples.

Current Behavior

Currently, we're sending the "receipt_email" parameter when a charge request is made within the API. This overrides the Stripe dashboard setting.

See here: https://stripe.com/docs/api/charges/create#create_charge-receipt_email

This results in our donors getting two email notifications. One from GiveWP and one From Stripe as well.

Expected Behavior

I expect to have the ability to choose whether Give sends the receipt or Stripe does and that if I configure things correctly then my donors will always only receive one notification email and it will be the one that I choose.

Bug Type

[X] This bug describes functionality that once worked as expected in version X.X.X.

Steps to Reproduce

1. With a test environment and test Stripe credentials, ensure your Stripe email notifications are turned off
2. Do a test donation with an email address you can receive emails from
3. Confirm that you got both a GiveWP email and a Stripe email

Visuals

Possible Solution

We can go two different routes on this:

1. Just don't send the "email_receipt" parameter to Stripe at all to prevent this in general
2. Provide a setting in our Stripe gateway settings page to control that completely from within Give.

Related

Two customer reports currently:

• https://secure.helpscout.net/conversation/917720400/0/?folderId=3046394
• https://secure.helpscout.net/conversation/917799742/44434?folderId=672194

Acceptance Criteria

• When Stripe email settings are disabled, Give doesn't override that setting and force Stripe to send an email anyway
• This is fixed both in the Stripe Free and Premium versions.

[allienimmons]

Two more tickets have come in about this: https://secure.helpscout.net/conversation/919000430/44524/ and https://secure.helpscout.net/conversation/918980620/0/?folderId=3046394