fix: prevent "this plugin does not have a valid header"

[Benunc]

Bug Report

User Story

As a user, I want to activate plugins directly from the licenses page via drag and drop.

Current Behavior

THe following add-ons return an error of "this plugin does not have a valid header" when attempting to activate from the licenses screen:

• Currency Switcher
• Fee Recovery
• Recurring Donations
• Stripe
• RazorPay
• Mollie
• Sofort
• Americloud

All of them activate without problems from the Plugins page, just not from the licenses tab of Give Settings.

Expected Behavior

I expect all add-ons to activate with no issue.

Bug Type

• This bug describes functionality that never worked as expected.

Steps to Reproduce

1. Install Give and navigate to Donations > Settings > Licenses
2. Drag and drop a zip of one of the plugins from the above list to the box.
3. Attempt to activate.

Visuals

Possible Solution

Related

#1208

Acceptance Criteria

• Currency Switcher activates with no issue
• Fee Recovery activates with no issue
• Recurring Donations activates with no issue
• Stripe activates with no issue
• RazorPay activates with no issue
• Mollie activates with no issue
• Sofort activates with no issue
• Americloud activates with no issue

Environment

Operating System

• Platform: Mac OS X
• Version: 10.14.6

Browser

• Name: Chrome
• Version: 76.0.3809.87 (Official Build) (64-bit)

WordPress System Info

### WordPress Environment ###

Home URL: http://samdestroysthings.local
Site URL: http://samdestroysthings.local
WP Version: 5.2.2
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: samdestroysthings.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: nginx/1.10.1
PHP Version: 7.1.4
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.5.3
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Database Tables: ✔ wp_give_donors - 1.0✔ wp_give_donormeta - 1.0✔ wp_give_comments - 1.0✔ wp_give_commentmeta - 1.0✔ wp_give_sessions - 1.0✔ wp_give_logs - 1.0✔ wp_give_logmeta - 1.0✔ wp_give_formmeta - 1.0✔ wp_give_sequential_ordering - 1.0✔ wp_give_donationmeta - 1.0
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://samdestroysthings.local/donation-confirmation/
Failure Page: http://samdestroysthings.local/donation-failed/
Donation History Page: http://samdestroysthings.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Stripe - Credit Card
Default Payment Gateway: Stripe - Credit Card
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled
Stripe Webhook Notifications: N/A

Active Give Add-ons

Other Active Plugins

Inactive Plugins

Ben's Helper Functions: by BenUNC –
Give - Sofort Payment Gateway: by WordImpress, CoachBirgit – 1.0
Nefarious Unknown Plugin: by Enron McEquifax – 1.3
Query Monitor: by John Blackbourn – 3.3.7
Tickera: by Tickera.com – 3.4.6.2

Active MU Plugins

index copy.php: by –

Theme

Name: Twenty Nineteen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme