fix: Show Stripe credit card form after upgrade when Stripe Checkout is not enabled

[mehul0810]

@mikejhale commented on Thu Sep 26 2019

Bug Report

User Story

As an org, I want existing and new donors to be able to make donations so that I can continue to accept payments without having to change my payment gateway options .

Cannot show Stripe Checkout page so new donors can't enter credit card. Previous donors are just billed right away with no option to change card and info. For new donors getting Post Intents errors in log because there is no payment method.

When a parent is entering a donation, the option to select a credit card is not coming up. If they are already in the system from a previous year (previous donation form), the card that was already in the system and attached to the email is getting charged automatically. If they are not in the system, it is not giving them a chance to put in their credit card details.

Current Behavior

With only Stripe - Credit Card enabled in Give 2.5.4 and Stripe 2.2.0, after upgrading to 2.5.7 and 2.2.1 existing donors are not able to change their credit card info and new donors cannot make donations

Expected Behavior

Existing donors have the option of checking their card and new donors can make donations.

Bug Type

• This bug describes functionality that once worked as expected in version 2.5.4
• This bug describes functionality that never worked as expected.
• I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

1. GiveWP core 2.5.4 or older
2. Stripe Premium 2.2.0 or older
3. Enable Stripe Credit Card in the settings at Donations > Settings > Payment Gateways > Stripe

4. Confirm it's working by testing a donation.
5. Update to the latest Give Core and Stripe Addon
6. Attempt a donation with an email that's already been used.
7. Attempt a donation with an email that's never been used.

Possible Solution

A possible workaround is to uncheck "Stripe - Credit Card" and check "Stripe Checkout" in Settings, and then save the settings.

Related

https://give.productboard.com/feature-board/879919-givewp-feature-hierarchy/features/2971861/detail

Acceptance Criteria

• Existing email is shown credit card form
• Donation is successfully made by existing email using Stripe Credit Card
• New donors see credit card form
• Donation is successfully made by new donor email using Stripe Credit Card