Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Sessions in Backend Prevents Errors from Displaying Properly #563

Closed
DevinWalker opened this issue Apr 5, 2016 · 3 comments
Closed

No Sessions in Backend Prevents Errors from Displaying Properly #563

DevinWalker opened this issue Apr 5, 2016 · 3 comments
Assignees
@DevinWalker
Milestone
1.4.1

Comments

@DevinWalker
Copy link
Member

As of 1.3.6 sessions are not started in the wp-admin, the problem with this is that we are outputting errors in wp-admin using give_set_error which uses sessions.

Related to: #521 #496

Be sure not to break functionality with Themefuse as well...
@DevinWalker DevinWalker added this to the 1.4.1 milestone Apr 5, 2016
@DevinWalker DevinWalker self-assigned this Apr 5, 2016
@DevinWalker
Copy link
Member Author

Also, we need to ensure errors are properly output in CMB2 general options: Give > Settings

@DevinWalker
Copy link
Member Author

Another note: you can test w/ the constant contact Add-on to see if errors are being properly output in wp-admin > Donations > Settings > Add-ons

DevinWalker pushed a commit that referenced this issue Apr 11, 2016
Tested #563 and give_set_error works well in admin
9fedf80
@DevinWalker DevinWalker added invalid and removed bug labels Apr 11, 2016
@DevinWalker
Copy link
Member Author

Upon further testing it appears working fine in admin with give_set_error

DevinWalker pushed a commit that referenced this issue Apr 11, 2016
Merge pull request #579 from WordImpress/issue/563
7df3257 
Tested #563 and give_set_error works well in admin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
1 participant
@DevinWalker