Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User able to donate minimum amount then custom minimum amount with multi level donation form #712

Closed
ravinderk opened this issue Jul 12, 2016 · 1 comment
Assignees
Milestone

Comments

@ravinderk
Copy link
Collaborator

User case: If custom amount is set to larger amount then minimum amount in multi donation form.

screen shot 2016-07-12 at 9 45 29 am

screen shot 2016-07-12 at 9 45 39 am

In this case user can donate minimum amount then custom minimum amount ( minimum amount should be present in multi level donation values), for other amount values we will get error.

multi donation form

My questions

  1. Is it necessary to give custom minimum amount setting to user?
  2. Can we set minimum amount to minimum amount in multi level donation form?
@mathetos
Copy link
Member

@ravinderk

I duplicated this issue with multi-level forms with a custom amount and custom minimum.

I think the intended behavior for the "Custom minimum Amount" field is to enforce that minimum, so that donors cannot give less than that amount at all.

So to your questions:

  1. Yes, because organizations get charged by the payment gateway for every transaction enforcing a minimum helps them reduce their fees. For example, PayPal charges 2.9% plus $0.30 per transaction. If a donor gives $1, the Org gets only $0.67 which means they lose 31% of that donation to fees. But if that same donor gave at least $10 then they only lose 6% per $10 transaction.

Secondly, thieves who steal Credit Card numbers often look for payment forms that they can test credit card numbers on. They'll use a form that allows for $1 donations and make a payment over and over with different numbers to test them. These are essentially "spam donations". Enforcing a minimum helps prevent those from happening.

  1. We should be able to, but clearly you've discovered a new bug. Thanks for reporting this!

@mathetos mathetos added the bug label Jul 15, 2016
@DevinWalker DevinWalker added this to the 1.7 milestone Aug 17, 2016
ravinderk added a commit to ravinderk/Give that referenced this issue Aug 22, 2016
DevinWalker pushed a commit that referenced this issue Aug 22, 2016
DevinWalker pushed a commit that referenced this issue Aug 22, 2016
DevinWalker pushed a commit that referenced this issue Aug 22, 2016
* release/1.7: (765 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...

# Conflicts:
#	assets/css/give-admin.min.css
#	assets/js/admin/admin-forms.js
#	assets/js/admin/admin-forms.min.js
#	assets/js/frontend/give.js
#	assets/js/frontend/give.min.js
#	assets/sourcemaps/give-admin.css.map
#	assets/sourcemaps/give.css.map
#	includes/admin/forms/metabox.php
#	includes/admin/payments/actions.php
#	includes/admin/payments/view-order-details.php
#	includes/admin/upgrades/upgrade-functions.php
#	includes/admin/upgrades/upgrades.php
#	includes/class-give-customer.php
#	includes/class-give-db.php
#	includes/class-give-donate-form.php
#	includes/class-give-stats.php
#	includes/emails/class-give-email-tags.php
#	includes/forms/functions.php
#	includes/forms/template.php
#	includes/payments/actions.php
#	includes/payments/class-give-payment.php
#	includes/payments/class-payments-query.php
#	includes/payments/functions.php
#	includes/price-functions.php
#	includes/scripts.php
#	includes/user-functions.php
#	readme.txt
#	templates/give.min.css
#	templates/shortcode-receipt.php
#	tests/framework/helpers/class-helper-form.php
#	tests/framework/helpers/class-helper-payment.php
#	tests/unit-tests/tests-payment-class.php
DevinWalker pushed a commit that referenced this issue Aug 22, 2016
* release/1.7: (929 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...
DevinWalker pushed a commit that referenced this issue Aug 22, 2016
* release/1.7: (66 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...

# Conflicts:
#	includes/forms/template.php
DevinWalker pushed a commit that referenced this issue Aug 22, 2016
* release/1.7: (316 commits)
  Change log added for #922
  Change log item for #896 added
  Change log for #712 added
  a11y: add H1 heading to admin "Donor" screen
  Document filter hooks
  Fix issues #712
  a11y: progress bar accessibility
  a11y: table accessibility in about page
  a11y: table accessibility in export page
  a11y: table accessibility in reports page, and remove un-needed labels and classes
  a11y: table accessibility in donor profile page
  a11y: table accessibility for [give_receipt] shortcode
  a11y: table accessibility for [donation_history] shortcode
  a11y: fix label `for` attribute to focus on the texarea `id`
  a11y: replace `title` attributes with `aria-label`
  Improved Add-on banner style
  Docs: update functions phpDocs
  Docs: document template action hooks
  Fixed variable name
  Fix failing test for file that we removed
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants