Use the_content to output Goal complete message #1545
#1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 24, 2017 12:07
2. Code reformat
I noticed that we were passing some default text in and the current field wasn't supporting that so I fixed it here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
oEmbeds and Shortcode support
As described in The new Goal Complete WYSIWYG doesn't currently render oEmbeds #1545 - we were outputting a notification for the Goal Complete message which closes the form from accepting further donations. This is pretty weak functionality. Likely, people would want to use this to output a shortcode, embed a video, etc.
WYSIWYGs now support
defaultarg.I noticed that we were passing some default text in and the current field wasn't supporting that so I fixed it here: 91e6923#diff-f3d5982e056a4167c9ee02f2c77d6031R392
Also reformatted the code to WP coding standards.
How Has This Been Tested?
Video Embed w/ YouTube:
Shortcode Usage:
Default content WYSIWYG support:
Types of changes
Checklist: