Issue/1715 #1885
Merged
Issue/1715 #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/2.0
Release/2.0
ravinderk
reviewed
Sep 19, 2017
includes/admin/admin-actions.php
Outdated
| $errors->add( 'empty_first_name', '<strong>ERROR:</strong>' . __( 'Please enter your first name.', 'give' ) ); | ||
| $errors->add( | ||
| 'empty_first_name', | ||
| sprintf( '%1$s %2$s', esc_html__( '<strong>ERROR:</strong>', 'give' ), __( 'Please enter your first name.', 'give' ) |
There was a problem hiding this comment.
@mehul0810 please separate HTML and translatable strings
sprintf(
'<strong>%1$s:</strong> %2$s',
__( 'ERROR', 'give' ),
__( 'Please enter your first name.', 'give' )
);
There was a problem hiding this comment.
@ravinderk Improved Code
# Conflicts: # assets/css/give-admin-rtl.min.css # assets/css/give-admin.min.css # assets/sourcemaps/give-admin.css.map
2 tasks
ravinderk
requested changes
Sep 20, 2017
includes/user-functions.php
Outdated
|
|
||
| } | ||
|
|
||
| add_action( 'user_register', 'give_add_past_donations_to_new_user' ); |
There was a problem hiding this comment.
@mehul0810 Remove this code because payments now connect with donor, so if user change or update it will not going to affect anything
4 tasks
|
@mehul0810
|
|
@ravinderk I have updated the validation so that it won't affect it any more and also checked the unit test to make sure it works. |
ravinderk
approved these changes
Sep 25, 2017
|
This is working well. I just tested on the large dataset from givewp.com and it upgraded nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for #1715
How Has This Been Tested?
I've tested this checking whether first name and last name of donor as well as user profile are in sync irrespective from where it is updated. I've implemented the change on updation of user profile from admin, donor profile from admin and
[give_profile_editor]shortcode update from front end.Also, divided single full name field for donor into first name and last name.
Screenshots (jpeg or gifs if applicable):
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: