Issues/1925 #1927
Merged
Issues/1925 #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
commented
Jul 29, 2017
| @@ -371,7 +371,7 @@ function give_format_decimal( $amount, $dp = false, $sanitize = true ) { | |||
| */ | |||
| function give_currency_filter( $price = '', $currency = '', $decode_currency = false ) { | |||
|
|
|||
| if ( empty( $currency ) ) { | |||
| if ( empty( $currency ) || ! array_key_exists( (string) $currency, give_get_currencies() ) ) { | |||
There was a problem hiding this comment.
@DevinWalker Review this condition improvement
|
@DevinWalker Merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will resolve #1925
How Has This Been Tested?
Review donor table and donor detail page
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: