Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/2101 #2111

Merged
merged 12 commits into from
Sep 25, 2017
Merged

Issues/2101 #2111

merged 12 commits into from
Sep 25, 2017

Conversation

ravinderk
Copy link
Collaborator

Description

This PR will fix #2101

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk
Copy link
Collaborator Author

@DevinWalker It will be good if will add last_changed to donor data in cache key name which will help to invalidate cache key.
For ref: https://github.com/easydigitaldownloads/easy-digital-downloads/blob/master/includes/class-edd-customer-query.php#L337

last_changed: we can store this key to the donor when donor update.

Currently, we have three hooks. These hooks do not contain similar param that means if they have first param as donor id then it will be good integration. Also, we can rename user -->donor.

'give_donor_post_create': When new donor creates
'give_donor_post_update': When donor updates
'give_user_profile_updated': When donor profile updates
give_edit_user_profile: When donor update using profile shortcode

Let me know what do you think?

For last_changed cache key logic we can implement that with our custom table. Let me know your view on this also.

@DevinWalker
Copy link
Member

👏🏻 Nice

@DevinWalker DevinWalker merged commit fda7ae4 into impress-org:release/1.8.14 Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants