Passing ID when getting currency through give_get_currency(). #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emgk please resolve the failing unit tests. |
ravinderk
reviewed
Oct 17, 2017
| * * | ||
| * @return int $decimals | ||
| */ | ||
| function give_currency_decimal_filter() { |
There was a problem hiding this comment.
@DevinWalker This function is deprecated. I also removed filter because give_get_price_decimals will handle this internally.
ravinderk
reviewed
Oct 17, 2017
| * @return mixed | ||
| */ | ||
| function give_get_price_decimals( $donation_id = null ) { | ||
| $setting = give_get_currency_formatting_settings( $donation_id ); | ||
| function give_get_price_decimals( $donation_or_form_id = null, $currency = '' ) { |
There was a problem hiding this comment.
@DevinWalker I updated give_get_price_decimals function.
ravinderk
reviewed
Oct 17, 2017
| * @return string The currency code | ||
| */ | ||
| function give_get_currency( $id = null ) { | ||
| function give_get_currency( $donation_or_form_id = null, $args = array() ) { |
There was a problem hiding this comment.
@DevinWalker I updated give_get_currency
|
@DevinWalker Merging this PR to core let me know if you have any suggestion or issue |
raftaar1191
added a commit
to raftaar1191/Give
that referenced
this pull request
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will resolve #2197.
Passing form_id or payment_id while getting the Give currency.
Checklist: