Issues/2397 #2399
Merged
Issues/2397 #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
commented
Nov 24, 2017
| @@ -419,177 +419,29 @@ function give_undo_donation( $payment_id ) { | |||
| * @return object $stats Contains the number of payments per payment status. | |||
| */ | |||
| function give_count_payments( $args = array() ) { | |||
There was a problem hiding this comment.
@DevinWalker I update this function and removed some unused filter also, let me know what do you think
There was a problem hiding this comment.
Let me know if you want to add backward compatibility for give_count_payments_where and give_count_payments_join
|
@ravinderk have a Question for you We can order table with donation from id, date etc but what I see is that I am not able to use any of the filter Is it normal?
|
|
@DevinWalker and @mehul0810 can you confirm sorting is working fine for you |
|
@ravinderk sorting what? |
|
@DevinWalker Sorting on donation listing page with filters |
|
@ravinderk looks like sorting is working but paging is broken https://goo.gl/qUqutJ Can you fix that ASAP? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
THIS PR WILL RESOLVE #2397
How Has This Been Tested?
Manually apply gateway sorting with form_id
Screenshots (jpeg or gifs if applicable):
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: