Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/2545 #2547

Merged
merged 1 commit into from
Dec 20, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions includes/admin/shortcodes/class-shortcode-button.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,27 +171,27 @@ public function shortcode_button() {

reset( $shortcodes );

if ( count( $shortcodes ) == 1 ) {
if ( 1 === count( $shortcodes ) ) {

$shortcode = key( $shortcodes );

printf(
'<button class="button sc-shortcode" data-shortcode="%s">%s</button>',
'<button type="button" class="button sc-shortcode" data-shortcode="%s">%s</button>',
$shortcode,
sprintf( '%s %s %s',
$img,
esc_html__( 'Insert', 'give' ),
__( 'Insert', 'give' ),
self::$shortcodes[ $shortcode ]['label']
)
);
} else {
printf(
'<div class="sc-wrap">' .
'<button class="button sc-button">%s %s</button>' .
'<button class="button sc-button" type="button">%s %s</button>' .
'<div class="sc-menu mce-menu">%s</div>' .
'</div>',
$img,
esc_html__( 'Give Shortcodes', 'give' ),
__( 'Give Shortcodes', 'give' ),
implode( '', array_values( $shortcodes ) )
);
}
Expand Down