Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of give_locate_template function : wrong params #2575

Closed
wants to merge 1 commit into from

Conversation

Mahjouba91
Copy link

Description

In the give_get_template function, the function calls give_locate_template function by passing two extra non required parameters $template_path and $default_path. But when we look at the give_locate_template function definition, we see that the last two parameters are not related to default path and template path, So it seems to be a little error of code.

By the way, when removing this little error, it seems that $template_path and $default_path parameters are never use in the give_get_template function except in filters, is this normal ?

How Has This Been Tested?

I did not test anything, just saw this error when trying to figure out if I had to use this function

Types of changes

Bug fix

@ravinderk
Copy link
Collaborator

@Mahjouba91 Thank you for PR.

I created an issue to improve give_locate_template fn #2577

@ravinderk ravinderk closed this Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants