feat(form): disallow email address as first name #2862 #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature helps reduce spam attacks which submits forms by filling the Name fields with email address. This will throw an error if the Name fields contain email addresses.
DevinWalker
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2862
Description
Created a new function
give_donation_form_validate_name_fields()which will check if the First and Last name fields contain email address or not.How Has This Been Tested?
This has been tested manually in logged-in and guest mode.
Video
https://www.useloom.com/share/a4f23a91aba74c0d83f2f8ccc85fec41
Checklist: