fix(admin-donation): add delete button on donations page #2734

[raftaar1191]

Description

PR to fix #2734

Notes: This PR contains the code of Modal API PR too so please merge the #2981 PR first in to Give release 2.1.0 and then this PR

How Has This Been Tested?

Manually Tested

Video/Screenshots (jpeg or gifs if applicable):

Video Link: https://screencast-o-matic.com/watch/cFfQIBDMgH

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows has proper inline documentation.

[DevinWalker]

I'm not a big fan of the button hanging out in the middle of the row like that. Needs some design work.

[raftaar1191]

@DevinWalker

We can move the delete button to below two section and I guess moving it on the right side will be a great option

[mathetos]

I'm not a fan of making it easier to delete donations in general. Users should rely on changing the donation status rather than deleting.

[DevinWalker]

Review Findings

@mathetos they can already delete in bulk on the donation listing screen so I don't think it's a big deal to add the ability to delete the individual donation payment. I just don't want a big glaring button in your face or anywhere that could accidentally be clicked.

Solution

Please see this InvisionApp concept: https://invis.io/WPGOUHCBKUX#/289312411_Hover

Basically it's a little mini-trashcan icon that hovers to red when clicked. This is blocked by the merging of the new Modal API.

[slewisma]

Adding a user's perspective here. Mixed feelings on this one. I like to easily be able to delete all the donations that were made in Test Mode after testing a new site. I worry about Give Managers and Admins deleting donations easily from an audit and anti-fraud perspective. Can the delete ability be controlled as a role capability separately from the overall Give Manager level?

I wonder how you will decide what deleting a donation means .... will a delete in Give be a trigger to Zapier for Actions of my choosing? Does a delete in Give tell a payment gateway to cancel a recurring donation? Do you have to prompt for all these decisions in the delete act? Or do you keep it simple and just delete the transaction or transactions chosen and leave any related cleanup to the person who is doing the deleting?

[DevinWalker]

Hey @slewisma - let me answer some of your questions:

I like to easily be able to delete all the donations that were made in Test Mode after testing a new site.

You can do this currently using the bulk option on the donation listing screen but not individually per donation.

Will a delete in Give be a trigger to Zapier for Actions of my choosing?

Yes if you have a Zap setup for the "Deleted Donation" action.

Does a delete in Give tell a payment gateway to cancel a recurring donation?

Not at this time, not. Nor does it refund it. I don't think deleting a donation should cancel a subscription. Subscription should be handled differently via the single subscription view.

Do you have to prompt for all these decisions in the delete act?

There will be a prompt confirming the admin wants to delete the donation. Not anything for refunding the payment first or anything related to adjusting stats or subscriptions.

Or do you keep it simple and just delete the transaction or transactions chosen and leave any related cleanup to the person who is doing the deleting?

We keep it pretty simple when deleting. However, we do automatically adjust stats when a donation payment is deleted.