fix(compat): prevent missing donation data with Restrict Content Pro #2710

[ravinderk]

Description

This PR will resolve #2710

How Has This Been Tested?

Tested with Restrict content pro 2.9.12

• Before and After 2.2.0 Give Db upgrades
  • New table in database with exiting data
  • Renamed payment_id column with donation_id
• With addons
  • Recurring
  • Currency Switcher
  • Fee recovery
• Tested backward comparibility for $wpdb property paymentmeta
• WordPress queries for getting payment meta

Screenshots (jpeg or gifs if applicable):

I did not replace$wpdb paymentmeta property to donationmeta in upgrades.php because that is old code and no need to update that code.

Checklist:

• Rename meta type payment --> donation
• Rename table {*}_give_paymentmeta --> {*}_give_donationmeta
• Add upgrade routine to rename table and payment_id --> donation_id column
• Test addon compatibility
• Write a blog post
• Create issue for documentation update

[raftaar1191]

Gettig PHP notice when viewing the Donor single page

Debug log

[24-May-2018 09:32:08 UTC] PHP Warning: Invalid argument supplied for foreach() in /app/public/wp-content/plugins/Give/includes/admin/donors/donors.php on line 342 [24-May-2018 09:32:08 UTC] PHP Stack trace: [24-May-2018 09:32:08 UTC] PHP 1. {main}() /app/public/wp-admin/edit.php:0 [24-May-2018 09:32:08 UTC] PHP 2. require_once() /app/public/wp-admin/edit.php:10 [24-May-2018 09:32:08 UTC] PHP 3. do_action() /app/public/wp-admin/admin.php:224 [24-May-2018 09:32:08 UTC] PHP 4. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453 [24-May-2018 09:32:08 UTC] PHP 5. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310 [24-May-2018 09:32:08 UTC] PHP 6. give_donors_page() /app/public/wp-includes/class-wp-hook.php:286 [24-May-2018 09:32:08 UTC] PHP 7. give_render_donor_view() /app/public/wp-content/plugins/Give/includes/admin/donors/donors.php:117 [24-May-2018 09:32:08 UTC] PHP 8. give_donor_view() /app/public/wp-content/plugins/Give/includes/admin/donors/donors.php:283

[raftaar1191]

@ravinderk this #3243 (comment) is not related to the above mention issues

I have create an new issues for this

#3259

[raftaar1191]

@ravinderk I tested this PR within Give Core as well as will Give Add-on everything is working fine

[ravinderk]

@mehul0810 fixed