fix(install): verify addon Give dependency before update #3217 #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
commented
May 28, 2018
includes/actions.php
Outdated
| 'Give_Addon_Update_Error', | ||
| sprintf( | ||
| __( 'You need Give version %s to update this plugin.', 'give' ), |
There was a problem hiding this comment.
@DevinWalker Need you help to update this text
There was a problem hiding this comment.
Give version %s is required to update this add-on.
raftaar1191
reviewed
May 28, 2018
| */ | ||
| function __construct( $file_url ) { | ||
| $this->file_url = $file_url; | ||
| $this->file_content = ! empty( $this->file_url ) ? file_get_contents( $this->file_url ) : ''; |
There was a problem hiding this comment.
In WordPress, we have a specific function to retrieve the content from URL
We should used that in place of Core PHP functions
https://codex.wordpress.org/Function_API/wp_remote_retrieve_body
|
@ravinderk I tested this PR by updating the Give Add-on plus non-Give Plugin to. It's working as expected and awesome
|
DevinWalker
reviewed
May 28, 2018
| */ | ||
| public function requires_at_least() { | ||
| // Regex to extract Give core minimum version from the readme.txt file. | ||
| preg_match('|Give requires at least:(.*)|i', $this->file_content, $_requires_at_least ); |
There was a problem hiding this comment.
Let's parse this text instead:
Requires Give: 2.1
1 task
|
@DevinWalker Changes done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will resolve #3217
How Has This Been Tested?
I tested this pr by updating multiple licensed Give addon.
Testing video: https://drive.google.com/file/d/1Jrdy9wQdiQirzid0CncdGmO9RyiSoECL/view?
usp=sharing
Snippet link: https://givewp.slack.com/files/U1DDJMUTV/FAWLZ3GSD/give_pull_3268.php
Checklist: