Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shortcode): select donation form alert must be open using modal api #3244 #3282 #3286 #3289

Merged
merged 1 commit into from
May 30, 2018

Conversation

Sidsector9
Copy link
Contributor

Closes #3282

Description

This PR replaces the native alert dialog with GiveModalWarning.

How Has This Been Tested?

By adding a form in a shortcode without choosing a form.

Screenshots (jpeg or gifs if applicable):

warning

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk ravinderk merged commit 61ba157 into release/2.1.4 May 30, 2018
@ravinderk ravinderk deleted the issue-3244v3 branch May 30, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants