Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-grid): resolve error where Payment Method shows with only one gateway enabled. #3293 #3298

Merged
merged 4 commits into from
May 31, 2018

Conversation

Sidsector9
Copy link
Contributor

Closes #3293

Description

This PR will only display the payment select fields only if there are more than 1 gateways enabled.

How Has This Been Tested?

I have tested this on the Form Grid page and individual Form page and tried all Display options.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@Sidsector9 Sidsector9 changed the title fix(form-grid): Display payment fields if enabled gateways > 1 fix(form-grid): resolve error where Payment Method shows with only one gateway enabled. #3293 May 31, 2018
@ravinderk
Copy link
Collaborator

@Sidsector9

I can see that if button mode enabled for form then you will see form title in the model but not for others. can you hide form title in the model for symmetry

image

@ravinderk ravinderk merged commit d4e95e2 into release/2.1.4 May 31, 2018
@raftaar1191 raftaar1191 self-requested a review June 1, 2018 05:37
@raftaar1191
Copy link
Contributor

Working fine as expected

@DevinWalker DevinWalker deleted the issue-3293v3 branch June 5, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants