fix(admin-tool): All Forms dropdown on the Donation Export only uses first ten forms #3303 #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raftaar1191
changed the title
ravinderk
requested changes
Jun 12, 2018
There was a problem hiding this comment.
@raftaar1191 can you confirm that form dropdown ajax supported or not
|
@ravinderk This PR is ready for review and merge |
|
Yes @ravinderk it support ajax form Search too |
ravinderk
requested changes
Jun 12, 2018
| @@ -189,6 +189,10 @@ function give_export_donation_form_search_args( $args ) { | |||
| $fields = isset( $_POST['fields'] ) ? $_POST['fields'] : null; | |||
| parse_str( $fields ); | |||
|
|
|||
| if ( ! empty( $give_forms_categories ) || ! empty( $give_forms_tags ) ) { | |||
There was a problem hiding this comment.
@raftaar1191 if ajax enabled for form for category and tag then why we have -1 here
There was a problem hiding this comment.
@raftaar1191 everything is good here
ravinderk
approved these changes
Jun 12, 2018
| @@ -189,6 +189,10 @@ function give_export_donation_form_search_args( $args ) { | |||
| $fields = isset( $_POST['fields'] ) ? $_POST['fields'] : null; | |||
| parse_str( $fields ); | |||
|
|
|||
| if ( ! empty( $give_forms_categories ) || ! empty( $give_forms_tags ) ) { | |||
There was a problem hiding this comment.
@raftaar1191 everything is good here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to fix #3303
How Has This Been Tested?
Tested by exporting donation by selecting the cat and tag and then exporting the donation
Video Link: https://screencast-o-matic.com/watch/cF1l1eFfAa
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: