Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shortcode): Add Company attribute to give_receipt shortcode #3361 #3364

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

ravinderk
Copy link
Collaborator

Description

This pr will resolve #3361

Note:
Company name field can be enabled only for specific form, show we cannot show & hide conditionally from shortcode builder that why I set it to display by default.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

Copy link
Contributor

@raftaar1191 raftaar1191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working Fine @ravinderk This PR is ready for merge

@ravinderk ravinderk merged commit 47388f9 into release/2.1.5 Jun 14, 2018
@ravinderk ravinderk deleted the issues/3361 branch June 14, 2018 07:02
@raftaar1191
Copy link
Contributor

raftaar1191 commented Jun 14, 2018

@ravinderk Here are the point that needs to be cover but the first two point are not done as expected. Third point is working fine

  • Ensure the company field is output (if present) in the output of the Donation Receipt by default
  • Add the Company field as an option in the Shortcode Builder with "Include" as the default value, with an additional option to "Exclude" it.
  • Ensure that the output of the donation receipt respects the new shortcode attribute when it's set to exclude the company field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants