fix(libraries): resolve tcpdf incompatibility with PHP 7.2 #3411 #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raftaar1191
changed the title
ravinderk
approved these changes
Jun 28, 2018
|
Call summery with @jaydeeprami and @raftaar1191 Call Summery Link: https://givewp.slack.com/archives/C0FAGC83C/p1530183053000178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to fix #3411
How Has This Been Tested?
Tested by exporting PDF from https://github.com/WordImpress/Give-PDF-Receipts/issues/145 and https://github.com/WordImpress/Give-Gift-Aid Add-on
Also tested by exporting PDF in PHP version 5.3 and PHP version 7.2 in both the version the PDF export featured is working fine
Screenshort
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: