Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-form): copy form shortcode to clipboard via button #2602 #3426

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

Sidsector9
Copy link
Contributor

@Sidsector9 Sidsector9 commented Jun 29, 2018

Closes #2602

Description

This PR replaces the old shortcode display with a shortcode button which on clicking will copy the shortcode.

How Has This Been Tested?

By clicking the shortcode button on both the donations listing page and on the form meta page.

Screenshots (jpeg or gifs if applicable):

Shortcode Button

shortcodebutton

Shortcode button on hover

shortcodebuttonhover

Shortcode button on click

shortcodebuttonclick

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@Sidsector9 Sidsector9 force-pushed the issue/2602v2 branch 2 times, most recently from 6e3a5e0 to 3fd87a5 Compare July 2, 2018 07:09
@DevinWalker
Copy link
Member

Looks great!

@@ -0,0 +1,30 @@
$wpbr-space: 20px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 please remove all references to WPBR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevinWalker I have made the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants