fix(db-update): resolve database updates not working due to inaccessible admin-ajax.php #3420 #3458
Conversation
…hen process completes
| if( ! give_test_ajax_works() ) { | ||
| echo sprintf( | ||
| '<div class="notice notice-warning inline"><p>%s</p></div>', | ||
| __( 'Admin ajax is inaccesible. We will update database with Ajax request instead of backgroud, so do not leave this page after starting database updates.', 'give' ) |
There was a problem hiding this comment.
@DevinWalker Need text for this notice
There was a problem hiding this comment.
Give is currently updating the database. Please do not refresh or leave this page while the update is in progress.
|
@DevinWalker Need help with this text:
This notice appears when ajax is inaccessible but now we can also run the update with Ajax instead of the background. @DevinWalker my second thought on this that maybe we do not need this message anymore because DB updates works ( either background or manually ) |
|
@Benunc Do we have staging site where we can test this pr? |
|
@DevinWalker I tired to create test video but my local server slows down when I start recording. |
|
@ravinderk yes I agree with you. If AJAX is inaccessible, we can now still run the update. So just don't display that message. |
|
@DevinWalker @Benunc I tested this code on Can you confirm? |
Description
This PR will resolve #3420
Note: Return
falsefromgive_test_ajax_worksto simulate ajax error.How Has This Been Tested?
Manually by running updates with pause and restart feature.
Checklist: